Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] add dynamic config.json path support #32

Open
sarathm09 opened this issue Sep 3, 2020 · 2 comments
Open

[request] add dynamic config.json path support #32

sarathm09 opened this issue Sep 3, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request planned Task is being planned
Milestone

Comments

@sarathm09
Copy link
Owner

No description provided.

@sarathm09 sarathm09 added the enhancement New feature or request label Sep 3, 2020
@sarathm09 sarathm09 added this to the 0.0.5 milestone Sep 3, 2020
@sarathm09 sarathm09 self-assigned this Sep 3, 2020
@sarathm09 sarathm09 added the planned Task is being planned label Sep 3, 2020
@sarathm09 sarathm09 assigned sarathm09 and unassigned sarathm09 Sep 3, 2020
@rahulbhargav
Copy link
Collaborator

@sarathm09 Can I work on this issue if no one else is working on it?
If so, can you provide some more information here?

@sarathm09
Copy link
Owner Author

@sarathm09 Can I work on this issue if no one else is working on it?
If so, can you provide some more information here?

This is a slightly tricky one.

As of now, before using vibranium in any system, there is this one task of initializing vibranium using a config.json. Though it has a lot of advantages like one time setup and having a global config, this imposes two limitations

  1. The is no way to have project specific configurations
  2. To run vibranium in some server (for example, as a jenkins job), the config.json needs to be maintained separately.

This issue is intended to remove this restriction. My proposal for this is as follows (please add your views)

  1. If the directory from which vibranium is run has a config.json available, then pick that file instead of the global config else pick the global one
  2. Add an option to specify the config file using some option like -c path/to/config.json and when specified, use that file instead of the one in the current directory or the global one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned Task is being planned
Projects
None yet
Development

No branches or pull requests

2 participants