diff --git a/samples/runner/dramtracer.go b/samples/runner/dramtracer.go index eaccf17a..e92524e8 100644 --- a/samples/runner/dramtracer.go +++ b/samples/runner/dramtracer.go @@ -45,6 +45,11 @@ func (t *dramTracer) StepTask(task tracing.Task) { // Do nothing } +// AddMilestone does nothing +func (t *dramTracer) AddMilestone(milestone tracing.Milestone) { + // Do nothing +} + // EndTask records the end of the task func (t *dramTracer) EndTask(task tracing.Task) { t.Lock() diff --git a/samples/runner/insttracer.go b/samples/runner/insttracer.go index a7775f1e..8a8f0924 100644 --- a/samples/runner/insttracer.go +++ b/samples/runner/insttracer.go @@ -51,6 +51,10 @@ func (t *instTracer) StepTask(task tracing.Task) { // Do nothing } +func (t *instTracer) AddMilestone(milestone tracing.Milestone) { + // Do nothing +} + func (t *instTracer) EndTask(task tracing.Task) { _, found := t.inflightInst[task.ID] if !found { diff --git a/samples/runner/timingplatform.go b/samples/runner/timingplatform.go index 16c119db..b7b01950 100644 --- a/samples/runner/timingplatform.go +++ b/samples/runner/timingplatform.go @@ -8,6 +8,7 @@ import ( memtraces "github.com/sarchlab/akita/v4/mem/trace" "github.com/sarchlab/akita/v4/analysis" + "github.com/sarchlab/akita/v4/datarecording" "github.com/sarchlab/akita/v4/mem/mem" "github.com/sarchlab/akita/v4/mem/vm" "github.com/sarchlab/akita/v4/mem/vm/mmu" @@ -15,7 +16,6 @@ import ( "github.com/sarchlab/akita/v4/noc/networking/pcie" "github.com/sarchlab/akita/v4/sim" "github.com/sarchlab/akita/v4/tracing" - "github.com/sarchlab/akita/v4/datarecording" "github.com/sarchlab/mgpusim/v4/driver" ) @@ -237,7 +237,6 @@ func (b *R9NanoPlatformBuilder) setupVisTracing() { // } visTracer := tracing.NewDBTracer(b.engine, be) - tracing.SetTracer(visTracer) visTracer.SetTimeRange(b.traceVisStartTime, b.traceVisEndTime) b.visTracer = visTracer diff --git a/timing/cu/cpistacktracer.go b/timing/cu/cpistacktracer.go index f3fe71ea..52b4a0e7 100644 --- a/timing/cu/cpistacktracer.go +++ b/timing/cu/cpistacktracer.go @@ -224,6 +224,11 @@ func (h *CPIStackTracer) StepTask(task tracing.Task) { // Do nothing } +// AddMilestone does nothing. +func (h *CPIStackTracer) AddMilestone(milestone tracing.Milestone) { + // Do nothing +} + // EndTask is called when a task is ended. func (h *CPIStackTracer) EndTask(task tracing.Task) { originalTask, found := h.inflightTasks[task.ID] diff --git a/timing/cu/isa_debugger.go b/timing/cu/isa_debugger.go index 537fc1dc..bad09cd1 100644 --- a/timing/cu/isa_debugger.go +++ b/timing/cu/isa_debugger.go @@ -57,6 +57,10 @@ func (h *ISADebugger) StepTask(task tracing.Task) { // Do nothing. } +func (h *ISADebugger) AddMilestone(milestone tracing.Milestone) { + // Do nothing. +} + // EndTask marks the end of an instruction. func (h *ISADebugger) EndTask(task tracing.Task) { originalTask, found := h.executingInst[task.ID] diff --git a/timing/rob/rob_test.go b/timing/rob/rob_test.go index ac5a8d39..f9b4b778 100644 --- a/timing/rob/rob_test.go +++ b/timing/rob/rob_test.go @@ -7,7 +7,6 @@ import ( "github.com/sarchlab/akita/v4/datarecording" "github.com/sarchlab/akita/v4/mem/mem" "github.com/sarchlab/akita/v4/sim" - "github.com/sarchlab/akita/v4/tracing" ) var dataRecorder *datarecording.SQLiteWriter @@ -28,8 +27,6 @@ var _ = BeforeSuite(func() { dataRecorder = datarecording.NewSQLiteWriter("") dataRecorder.Init() engine = sim.NewSerialEngine() - tracer := tracing.NewDBTracer(engine, dataRecorder) - tracing.SetTracer(tracer) }) var _ = AfterSuite(func() {