From f3b0b8cc5cf6253eecc6e00c09a8213555062023 Mon Sep 17 00:00:00 2001 From: Yifan Sun Date: Mon, 27 Nov 2023 07:43:21 -0700 Subject: [PATCH] Apply suggestions from code review Minor changes in formats --- timing/cu/issuearbiter.go | 3 ++- timing/cu/vectormemoryunit.go | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/timing/cu/issuearbiter.go b/timing/cu/issuearbiter.go index 76cb734b..7171bb96 100644 --- a/timing/cu/issuearbiter.go +++ b/timing/cu/issuearbiter.go @@ -34,8 +34,8 @@ func (a *IssueArbiter) Arbitrate( } a.moveToNextSIMD(wfPools) } - if len(wfPools[a.lastSIMDID].wfs) != 0 { + if len(wfPools[a.lastSIMDID].wfs) != 0 { typeMask := make([]bool, 7) wfPool := wfPools[a.lastSIMDID] for _, wf := range wfPool.wfs { @@ -49,6 +49,7 @@ func (a *IssueArbiter) Arbitrate( } } } + if a.lastSIMDID == originalSIMDID { break } diff --git a/timing/cu/vectormemoryunit.go b/timing/cu/vectormemoryunit.go index ba93b0ea..8b571336 100644 --- a/timing/cu/vectormemoryunit.go +++ b/timing/cu/vectormemoryunit.go @@ -111,7 +111,6 @@ func (u *VectorMemoryUnit) insertTransactionToPipeline( func (u *VectorMemoryUnit) execute(now sim.VTimeInSec) (madeProgress bool) { item := u.postInstructionPipelineBuffer.Peek() if item == nil { - u.postInstructionPipelineBuffer.Pop() return false }