Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For structured output via response_format remove the restriction of using jsonschema package. #829

Closed
samarthpatil00 opened this issue Aug 21, 2024 · 1 comment
Closed

For structured output via response_format remove the restriction of using jsonschema package. #829

samarthpatil00 opened this issue Aug 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@samarthpatil00
Copy link

samarthpatil00 commented Aug 21, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • In the latest implementation for structured output the ChatCompletionResponseFormatJSONSchema struct accepts field Schema as a type of jsonschema.Definition this makes it hard to integrate with other json schema libraries or passing our own raw json schema.

Describe the solution you'd like

  • Make the type of schema in ChatCompletionResponseFormatJSONSchema to any, as it is done in FunctionDefinition. In FunctionDefinition we can pass anything in Parameters as long as it is json marshallable
@samarthpatil00 samarthpatil00 added the enhancement New feature or request label Aug 21, 2024
@samarthpatil00 samarthpatil00 mentioned this issue Aug 22, 2024
Closed
@samarthpatil00
Copy link
Author

Closing the issue since #819 fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samarthpatil00