-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential place the migrator should error out #119
Comments
Yeah, it looks like Bootstrap 3 assumes that its stylesheets are imported in a shared scope in a particular order, so it's not possible to just Catching this is tricky, since we need to somehow detect when a stylesheet that is being migrated depends on stylesheets that aren't being migrated in an order-dependent way. |
Could we combine the existing logic for detecting if a member is being used from a scope it can't import with the logic for detecting if a member needs to be renamed in an un-migrated dependency? |
A user on twitter has reported a case where the migrator takes valid Sass and produces what seems to be invalid Sass. @jathak can you investigate? I think this might be because it used to be loading stuff into the global scope which it's not anymore.
The text was updated successfully, but these errors were encountered: