Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential place the migrator should error out #119

Open
nex3 opened this issue Oct 22, 2019 · 2 comments
Open

Potential place the migrator should error out #119

nex3 opened this issue Oct 22, 2019 · 2 comments
Labels
enhancement New feature or request module system Part of the module system migrator

Comments

@nex3
Copy link
Contributor

nex3 commented Oct 22, 2019

A user on twitter has reported a case where the migrator takes valid Sass and produces what seems to be invalid Sass. @jathak can you investigate? I think this might be because it used to be loading stuff into the global scope which it's not anymore.

@jathak
Copy link
Member

jathak commented Oct 22, 2019

Yeah, it looks like Bootstrap 3 assumes that its stylesheets are imported in a shared scope in a particular order, so it's not possible to just @use particular files.

Catching this is tricky, since we need to somehow detect when a stylesheet that is being migrated depends on stylesheets that aren't being migrated in an order-dependent way.

@nex3 nex3 closed this as completed Oct 22, 2019
@nex3 nex3 reopened this Oct 22, 2019
@nex3
Copy link
Contributor Author

nex3 commented Oct 22, 2019

Could we combine the existing logic for detecting if a member is being used from a scope it can't import with the logic for detecting if a member needs to be renamed in an un-migrated dependency?

@nex3 nex3 added the module system Part of the module system migrator label Feb 4, 2020
@jathak jathak added the enhancement New feature or request label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module system Part of the module system migrator
Projects
None yet
Development

No branches or pull requests

2 participants