Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @extend in the module migrator #120

Open
jathak opened this issue Oct 24, 2019 · 2 comments
Open

Support @extend in the module migrator #120

jathak opened this issue Oct 24, 2019 · 2 comments
Labels
enhancement New feature or request module system Part of the module system migrator

Comments

@jathak
Copy link
Member

jathak commented Oct 24, 2019

The migrator should add additional @use rules to ensure that selectors being extended are upstream of the extending selector.

An internal team ran into this issue when migrating. The compiler saved them for extended placeholder selectors, but not for a concrete selector that was also present within the same stylesheet as the @extend (which they didn't notice until their screenshot tests failed).

@jathak
Copy link
Member Author

jathak commented Oct 24, 2019

@nex3: Do you know what the right way to go about doing this would be? Would having References track extensions make sense?

@nex3
Copy link
Contributor

nex3 commented Oct 24, 2019

That sounds like a reasonable place to start, yeah.

@nex3 nex3 added the module system Part of the module system migrator label Feb 4, 2020
@jathak jathak added the enhancement New feature or request label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module system Part of the module system migrator
Projects
None yet
Development

No branches or pull requests

2 participants