Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant @use rules #135

Open
nex3 opened this issue Jan 28, 2020 · 1 comment
Open

Remove redundant @use rules #135

nex3 opened this issue Jan 28, 2020 · 1 comment
Labels
enhancement New feature or request module system Part of the module system migrator

Comments

@nex3
Copy link
Contributor

nex3 commented Jan 28, 2020

Currently, if a file contains an @import rule that loads a file F as well as an implicit reference to a member loaded from a file G that forwards F, the migrator will generate @use rules for both F and G when only generating one for G would suffice.
@nex3
Copy link
Contributor Author

nex3 commented Jan 28, 2020

I think this may require restructuring how @use rules are generated. Rather than lazily adding rules when a member use is encountered from a file that hasn't been @used yet, References could track all upstream files for a given source file and the migrator could eagerly generate @uses based on that information.

@nex3 nex3 added the module system Part of the module system migrator label Feb 4, 2020
@jathak jathak added the enhancement New feature or request label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module system Part of the module system migrator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @jathak