-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for binary operations #1013
Labels
Comments
nex3
added a commit
that referenced
this issue
Dec 19, 2016
The deleted tests had large inputs in which one line errored and all other lines were ignored, and as such weren't particularly useful. New specs should be added for these; see #1013.
nex3
added a commit
that referenced
this issue
Dec 19, 2016
The deleted tests had large inputs in which one line errored and all other lines were ignored, and as such weren't particularly useful. New specs should be added for these; see #1013.
nex3
added a commit
that referenced
this issue
Dec 19, 2016
The deleted tests had large inputs in which one line errored and all other lines were ignored, and as such weren't particularly useful. New specs should be added for these; see #1013.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All the binary operations need thorough tests that exercise their edge and error cases. Most existing specs in
spec/parser/operations
have individual lines that produce errors, which means that almost nothing is being tested in practice. I intend to remove those specs.Ruby Sass has pretty good coverage for binary operations, which can be ported over.
The text was updated successfully, but these errors were encountered: