Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic loading capability to our app #32

Open
nadvolod opened this issue Jun 15, 2020 · 8 comments
Open

Add dynamic loading capability to our app #32

nadvolod opened this issue Jun 15, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@nadvolod
Copy link

I've had a few customers that are using Screener-runner and they have page elements that dynamically load when scrolled into view. Sometehing like this page: https://ultimateqa.com/

Can we add some page to our app that has this functionality so that I can create demo scripts to run against it?

@nadvolod
Copy link
Author

@wswebcreation after 2 customers 2 weeks in a row have had the same issues with Visual, I want to start working towards making this feature available. Here is what we would need in the app to help customers with better visual testing.
It could be one or multiple pages with the following features:

  • Lazy loading of the application so that as you scroll past elements, they load into view
  • A spinner that loads a page for a random period of time, forcing the user to wait before a snapshot
  • A slider where the elements keep changing, creating an unstable view for the customer, making snapshots hard

I am happy to try and create a PR for this when I have time (I've been doing some React development in my spare time and I'm really enjoying it). I just wanted to share my idea with you and make sure that it's acceptable?

@wswebcreation
Copy link
Contributor

Hi @nikolay-advolodkin

Feel free to create a PR which is non breaking for the rest 😉

@nadvolod
Copy link
Author

@wswebcreation great. Where do you think is a reasonable place to add such a page? I think in the hamburger menu on the left I could add a page and call it like "Dynamic Catalog"

@nadvolod nadvolod self-assigned this Jan 24, 2022
@wswebcreation
Copy link
Contributor

Yep, that would be a good solution

@diemol
Copy link
Member

diemol commented Jul 3, 2023

Is this still relevant or can we close this?

@nadvolod
Copy link
Author

nadvolod commented Jul 3, 2023

@diemol still need this. Will be very valuable when visual is launched. This is a common issue customers deal with when working with visual testing

@diemol
Copy link
Member

diemol commented Jul 3, 2023

Did you get somewhere with your PR?

@nadvolod
Copy link
Author

nadvolod commented Jul 3, 2023

🤣 C'mon Diego, do you think I have time for a nice-to-have feature in our dummy app? I wish! This will need to get prioritized by customer requests when we have the new visual. Then I can add the feature and the test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants