Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incosistency in the CityGML dataset #5

Open
35 tasks
OloOcki opened this issue Dec 9, 2020 · 4 comments
Open
35 tasks

Incosistency in the CityGML dataset #5

OloOcki opened this issue Dec 9, 2020 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@OloOcki
Copy link
Collaborator

OloOcki commented Dec 9, 2020

This is a threat concerning inconsistency within the presented CityGML dataset. The threat will be updated periodically.

Albeit great effort to ensure geometrical and semantical consistency in modeling there could be some deviations present within the model. Thus, here is the list of things to be fixed:

Remap geometry:

  • line id201 cityObjectMember
  • line UUID_e9bc7d3f-4abf-40b3-bf55-864517e6b05c cityObjectMember building
  • line UUID_1432b984-e0fb-4ddf-8cf3-29c1907d0383 cityObjectMember building
  • line UUID_b7042412-f37d-48a0-b9bc-478f2dbba01c cityObjectMember building
  • line UUID_69ea336f-37ff-4a4c-a0e7-6027a7987a7f cityObjectMember building
  • line UUID_a25806b0-70e2-4218-a7f0-52b904b5dd3e cityObjectMember building
  • line UUID_824bd839-4a07-447f-bf4f-770ffa611314 cityObjectMember building
  • line UUID_24eb44fb-8332-490f-a0cf-5ddf01614326 cityObjectMember building
  • line UUID_5d5fb79b-d106-4e9f-b871-74ac54465100 cityObjectMember building
  • line UUID_f1614d34-beef-4538-988b-5184defb9053 cityObjectMember building
  • line UUID_cc9a72c1-6b53-44e5-9148-314cab2997ca cityObjectMember building
  • line UUID_6773c2e8-ba0d-4680-897c-26490ea6c1fc_BP.w8OJH2XnTm8nLMOllRO6 outerBuildingInstallation
  • line UUID_6773c2e8-ba0d-4680-897c-26490ea6c1fc_BP.vXbjZcrVTsqPEFT9NgrO outerBuildingInstallation
  • line UUID_e9bc7d3f-4abf-40b3-bf55-864517e6b05c_BP.rRV85YWEvtoxzgbaz3Ji outerBuildingInstallation
  • line UUID_e9bc7d3f-4abf-40b3-bf55-864517e6b05c_BP.dBwtygFwJoCHhXoNordR outerBuildingInstallation
  • line UUID_e9bc7d3f-4abf-40b3-bf55-864517e6b05c_BP.UObMrLRERK9cmrUP7jK0 outerBuildingInstallation
  • line UUID_b98cb0ba-d4a2-4b08-8247-3a0ddfebf919_BP.uDrjVwwooM3Zgf4Y6e6E outerBuildingInstallation
  • line UUID_b7042412-f37d-48a0-b9bc-478f2dbba01c_BP.byK9NldHkNEN9zk5zVs0 outerBuildingInstallation
  • line UUID_b7042412-f37d-48a0-b9bc-478f2dbba01c_BP.7mhpZf7uRrtLafVYTczv outerBuildingInstallation
  • line UUID_b7042412-f37d-48a0-b9bc-478f2dbba01c_BP.LXRueUbKd0P6mO8BOPi5 outerBuildingInstallation
  • line UUID_b7042412-f37d-48a0-b9bc-478f2dbba01c_BP.otsmKRUlQd4nCi2MCb1T outerBuildingInstallation
  • line UUID_a25806b0-70e2-4218-a7f0-52b904b5dd3e_BP.SY66M0lcIFKxQVWueX3M outerBuildingInstallation
  • line UUID_a25806b0-70e2-4218-a7f0-52b904b5dd3e_BP.4SbRuBprWb7FnCZ7lLXj outerBuildingInstallation
  • line UUID_a25806b0-70e2-4218-a7f0-52b904b5dd3e_BP.zkomaDq05vIwDXLcjJte outerBuildingInstallation
  • line UUID_a25806b0-70e2-4218-a7f0-52b904b5dd3e_BP.4bq9D0ev8Jwi7bLYDxDX outerBuildingInstallation
  • line UUID_a25806b0-70e2-4218-a7f0-52b904b5dd3e_BP.2CxI5fRSW51So8SFascQ outerBuildingInstallation
  • line UUID_03dd9598-d5d7-42fe-ad15-42b5d9f515f3_BP.kfqW0QvzseoWVaJNKSfw outerBuildingInstallation
  • line UUID_03dd9598-d5d7-42fe-ad15-42b5d9f515f3_BP.RjHpZ72cDXO4DT5y0Tpf outerBuildingInstallation
  • line UUID_824bd839-4a07-447f-bf4f-770ffa611314_BP.t5evJECRnn3HvcAwbSpa outerBuildingInstallation
  • line UUID_24eb44fb-8332-490f-a0cf-5ddf01614326_BP.4EaXoemgsVrCSIxqF4he outerBuildingInstallation
  • line UUID_9ec08f55-b504-4dab-a8c7-78d4388a818b_BP.eNyZxfkNq1223fV7xonz outerBuildingInstallation
  • line UUID_9ec08f55-b504-4dab-a8c7-78d4388a818b_BP.B80eYl9EOmMXiIHwjeBj outerBuildingInstallation
  • line UUID_9ec08f55-b504-4dab-a8c7-78d4388a818b_BP.J253gouqdyFRFgUqEgzo outerBuildingInstallation
  • line UUID_9ec08f55-b504-4dab-a8c7-78d4388a818b_BP.4IZR3qdsX63rtKSNGoqM outerBuildingInstallation
  • line UUID_5d5fb79b-d106-4e9f-b871-74ac54465100_BP.vSqezYmcZXNPD5cGx2od outerBuildingInstallation
@OloOcki OloOcki self-assigned this Dec 9, 2020
@OloOcki OloOcki added bug Something isn't working enhancement New feature or request labels Dec 9, 2020
@benediktschwab
Copy link
Member

great @OloOcki!
I will try to coordinate this with @Sophie876.

Do we also need to update the creation guidelines regarding the discovered inconsistencies?

@OloOcki
Copy link
Collaborator Author

OloOcki commented Dec 10, 2020

I guess that it would be nice to have a short list of things that have to be carefully examined. Likes of empty/not empty geometry check, homogeneity check among others. I guess that a list of possible inconsistencies might expand together with the project's expansion.

I recommend to create a FME workspace that will be capable to perform validation of consistency (especially focusing on the geometry but also semantics) and attach it to the repo. The workflow should evolve with the project.

@Sophie876
Copy link

Thank you for the thread @OloOcki!
I found the listed things in the model, using FME.
Can you clarify what exactly has to be fixed for them? Are they not correctly assigned to the CityGML Group Types?

Is it correct that e.g. "line UUID_6773c2e8-ba0d-4680-897c-26490ea6c1fc_BP.w8OJH2XnTm8nLMOllRO6 outerBuildingInstallation" indicates that this should be assigned to outerBuildingInstallation, which at the moment is not the case?
Do you have a hint for how this can be done using the CityEditor Plugin in SketchUp? For the assignment to Group Types I can choose between BuildingInstallation, BuildingPart, Door, IntBuildingInstallation, Room and Window. (For the Opening Boundary Surface Type the options are Ceiling Surface, ClosureSurface, FloorSurface, GroundSurface, InteriorWallSurface, OuterCeilingSurface, OuterFloorSurface, RoofSurface and WallSurface).
For "line id201 cityObjectMember" and
"line UUID_e9bc7d3f-4abf-40b3-bf55-864517e6b05c cityObjectMember building" I am not sure what is the issue exactly, thank you if you could explain this, too!

@OloOcki
Copy link
Collaborator Author

OloOcki commented Dec 21, 2020

@Sophie876 for now the aforementioned logs are just to point out where a problem exists without a detailed description. I totally agree that it is rather hard to understand the meaning behind them. Thus, the planned validating tool in a FME workspace should provide more meaningful logs. Thanks for your feedback!

At the very beginning the dataset was created without a geometrical representation in a Building class. Thus, this class should be empty w.r.t. geometry. For example, id201 is an unique ID of a Building and it contains a geometry (line). This is an incosistency in the dataset and stands as a problem for further processing.

The question regarding the UUID_6773c2e8-ba0d-4680-897c-26490ea6c1fc_BP.w8OJH2XnTm8nLMOllRO6 ID means that there are multiple geometries present (lines + surfaces) in the class which is not desired. The geometry should be homogen (in our case only surfaces).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants