Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIT MODE: execution flags and run configuration #230

Closed
orchestr7 opened this issue Sep 1, 2021 · 3 comments · Fixed by #236
Closed

LIT MODE: execution flags and run configuration #230

orchestr7 opened this issue Sep 1, 2021 · 3 comments · Fixed by #236
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@orchestr7
Copy link
Member

orchestr7 commented Sep 1, 2021

LIT contains two functionalities that we need to support:

  1. Support inline fixers for fix and warn plugin #221
  2. RUN configuration:
    // RUN: %check_clang_tidy %s huawei-unspecified-array-size %t

In this task we need to support execution flags and run configuration on plugin level (but functionality should be common for plugins...)

RUN configuration should be ignored during the calculation of line numbers.

@orchestr7 orchestr7 added the enhancement New feature or request label Sep 1, 2021
@orchestr7 orchestr7 added this to the 0.2.0 milestone Sep 1, 2021
@orchestr7
Copy link
Member Author

This issue should also cover cases when we would like to add something in the end of our execution command AFTER file names.

@petertrr
Copy link
Member

petertrr commented Sep 1, 2021

Discussed and decided to do the following:
execFlags in save.toml can be extended with values from the file (comment format should be configurable via config file):

// RUN: extraFlagsBefore=stuff, extraFlagsAfter=stuff2

and then these variables can be used as placeholders:

execFlags = "-F $extraFlagsBefore $files $extraFlagsAfter"

or

[warn]
execFlags = "--fix $FLAGS $FILENAME $EXTRA_FLAGS"

@orchestr7
Copy link
Member Author

LIT can contain SEVERAL RUN commands on the same file... Probably we should create an issue for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants