-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatize yarn.lock
or remove it
#519
Comments
|
Without a lockfile, yarn/npm will always resolve version ranges each time build is performed. Some time ago, there was an incident when this setup caused all Kotlin installations to download a certain dependency version that contained malware. Since then, having Here is the blog post about the original issue: https://blog.jetbrains.com/kotlin/2021/10/important-ua-parser-js-exploit-and-kotlin-js/ |
we have it as a separate task in save-cloud, but we don't have such in save-cli
honestly, I don't understand why we need
yarn.lock
insave-cli
: it doesn't have JS executable artifact, only as a library (and it's a pure kotlin app). Will create an issue for it (if we need theyarn.lock
, will create a task for it as insave-cloud
),And still it can fail: even in
save-cloud
, the taskkotlinUpgradeYarnLock
is separate and if JS dependency changed by upgrading the kolin (as we see it here) -- it failsOriginally posted by @nulls in #518 (comment)
The text was updated successfully, but these errors were encountered: