Audio API changes #797
Open
Audio API changes #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Jul 23, 2023
yilinwei
commented
Sep 18, 2023
|
@yilinwei is this PR ready-for-review? otherwise do you mind if we mark as draft so you can un-draft it when it's ready :) |
|
It's not ready, I'm still slowly playing around with the APIs to make sure
they're correct.
Please mark it as a draft; I didn't realise that was a feature at all!
…On Tue, 26 Sep 2023, 16:55 Arman Bilge, ***@***.***> wrote:
@yilinwei <https://github.com/yilinwei> is this PR ready-for-review?
otherwise do you mind if we mark as draft so you can un-draft it when it's
ready :)
—
Reply to this email directly, view it on GitHub
<#797 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEE6CADCHUR3XPZBCRIU53X4L3HNANCNFSM6AAAAAA2UB4UV4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
yilinwei
commented
Dec 20, 2023
dom/src/main/scala/org/scalajs/dom/AudioWorkletGlobalScope.scala
Outdated
Show resolved
Hide resolved
|
Thank you for this! I'll find some time to review this ASAP, and we're hoping to cut a release (with this PR) sometime in January. |
zetashift
reviewed
Jan 28, 2024
dom/src/main/scala/org/scalajs/dom/AudioBufferSourceNodeOptions.scala
Outdated
Show resolved
Hide resolved
dom/src/main/scala/org/scalajs/dom/AudioNodeChannelInterpretation.scala
Outdated
Show resolved
Hide resolved
dom/src/main/scala/org/scalajs/dom/AudioNodeChannelCountMode.scala
Outdated
Show resolved
Hide resolved
dom/src/main/scala/org/scalajs/dom/AudioWorkletGlobalScope.scala
Outdated
Show resolved
Hide resolved
|
Thanks! I've addressed all the feedback - let me know if we've missed anything. |
zetashift
approved these changes
Jan 28, 2024
|
Thank you both a lot for this! I'll wait till @armanbilge reviewed this as well before merging, because reviewing is quite a manual task and I might have missed something. |
|
@armanbilge would you be able to take a look when you have the chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in progress at the moment, since I have an active project which is binding to most of these methods.
I'm opening it, mainly so that there's some visibility on the changes which I'm in the progress of making.
I haven't copy-pasted the docs nor run some of the release reports yet and won't until I finish the changes.
EDIT:
This is ready for review/merging.