Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify sbt output parsing to allow .sbtopts with modified output #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Modify sbt output parsing to allow .sbtopts with modified output #20

wants to merge 5 commits into from

Conversation

kalejami
Copy link

@kalejami kalejami commented Dec 13, 2023 •
edited
Loading

Issue #19

Michael Kaleja added 2 commits December 13, 2023 09:52
Added .sbtopts which modifies the output of sbt to the testproject. R…
88bd3b8 
…esult: All tests will fail because main.js path is not the expected one
dev: modified the output-parsing to find (probably) the right path to…
1baf181 
… the main.js file. Also make it work for win-platform
@kalejami kalejami changed the title Modify sbt output parsing to allow .sbtopts with modified output (#19) Modify sbt output parsing to allow .sbtopts with modified output Dec 13, 2023
@cornerman
Copy link

Great that you looked into this!
An alternative might be to search for the last line starting with a /, because afaik sbt will only return absolute paths here.

@kalejami
Copy link
Author

kalejami commented Feb 5, 2024

Great that you looked into this! An alternative might be to search for the last line starting with a /, because afaik sbt will only return absolute paths here.

But probably only for non-win-platforms 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalejami @cornerman