From 00bae40eb3a99e4d40058d7c11017e92fcb89a06 Mon Sep 17 00:00:00 2001 From: Maha Benzekri Date: Tue, 19 Nov 2024 18:38:16 +0100 Subject: [PATCH] fixup post reviews --- .github/workflows/tests.yaml | 8 +++++++- package.json | 4 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index c730aabde..fd52f3468 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -43,13 +43,19 @@ jobs: sudo sh -c "echo '127.0.0.1 testrequestbucket.localhost' >> /etc/hosts" - name: test and coverage run: yarn --silent coverage + env: + NODE_OPTIONS: "--tls-max-v1.2" - name: run functional tests run: yarn ft_test - uses: codecov/codecov-action@v4 with: token: ${{ secrets.CODECOV_TOKEN }} + - name: install dependencies for executables tests + run: yarn install - name: run executables tests - run: yarn install && yarn test + run: yarn test + env: + NODE_OPTIONS: "--tls-max-v1.2" working-directory: 'lib/executables/pensieveCreds/' compile: diff --git a/package.json b/package.json index aca05b9a9..0b8d23b75 100644 --- a/package.json +++ b/package.json @@ -84,11 +84,11 @@ "lint": "eslint $(git ls-files '*ts' ' *.js')", "lint_md": "mdlint $(git ls-files '*.md')", "lint_yml": "yamllint $(git ls-files '*.yml')", - "test": "export NODE_OPTIONS=\"--tls-max-v1.2\" && jest tests/unit --detectOpenHandles", + "test": "jest tests/unit --detectOpenHandles", "build": "tsc", "prepare": "yarn build", "ft_test": "jest tests/functional --testTimeout=120000 --forceExit", - "coverage": "export NODE_OPTIONS=\"--tls-max-v1.2\" && nyc --clean jest tests --coverage --testTimeout=120000 --forceExit", + "coverage": "nyc --clean jest tests --coverage --testTimeout=120000 --forceExit", "build_doc": "cd documentation/listingAlgos/pics; dot -Tsvg delimiterStateChart.dot > delimiterStateChart.svg; dot -Tsvg delimiterMasterV0StateChart.dot > delimiterMasterV0StateChart.svg; dot -Tsvg delimiterVersionsStateChart.dot > delimiterVersionsStateChart.svg" }, "private": true,