Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/arsn 372 remove mpu location from listing result to speedup result #2184

Conversation

KillianG
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Nov 13, 2023

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@KillianG KillianG force-pushed the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch from 13e28a4 to 2537f8a Compare November 13, 2023 10:07
@scality scality deleted a comment from bert-e Nov 13, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 13, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@KillianG KillianG force-pushed the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch from 1760627 to 52875fe Compare November 16, 2023 13:16
@scality scality deleted a comment from codecov-commenter Nov 17, 2023
@KillianG KillianG force-pushed the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch 2 times, most recently from 73f1bad to 83ca124 Compare November 17, 2023 14:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7866a1d) 64.35% compared to head (83ca124) 64.35%.

Additional details and impacted files
@@               Coverage Diff                @@
##           development/8.1    #2184   +/-   ##
================================================
  Coverage            64.35%   64.35%           
================================================
  Files                  210      210           
  Lines                16396    16397    +1     
  Branches              3320     3320           
================================================
+ Hits                 10552    10553    +1     
  Misses                5829     5829           
  Partials                15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KillianG KillianG force-pushed the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch from 83ca124 to d5b4ca8 Compare November 17, 2023 14:27
@KillianG KillianG force-pushed the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch 4 times, most recently from c5e2811 to 842b102 Compare November 17, 2023 15:36
test to check for location param is absent

Issue: ARSN-372
@KillianG KillianG force-pushed the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch from 842b102 to 4b642cf Compare November 17, 2023 16:45
@KillianG
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue ARSN-372.

Goodbye killiang.

@bert-e bert-e merged commit 4b642cf into development/8.1 Nov 20, 2023
7 checks passed
@bert-e bert-e deleted the improvement/ARSN-372-Remove-MPU-location-from-listing-result-to-speedup-result branch November 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants