Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1834 check for active connections on prestop #153

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jun 26, 2024

While nginx -s quit does a graceful shutdown, it may shutdown (not so gracefully) connections done with keepalive. Which is typically the operations seen in promotions.

@tcarmet tcarmet requested a review from a team as a code owner June 26, 2024 09:52
@tcarmet tcarmet force-pushed the bugfix/PTFE-1834-check-active-connection-prestop branch from 1080792 to 0e85610 Compare June 26, 2024 09:56
@tcarmet tcarmet added the bug Something isn't working label Jun 26, 2024
@tcarmet tcarmet force-pushed the bugfix/PTFE-1834-check-active-connection-prestop branch from 0e85610 to 33a4d78 Compare June 26, 2024 11:33
@tcarmet tcarmet force-pushed the bugfix/PTFE-1834-check-active-connection-prestop branch from 33a4d78 to 8e57e48 Compare June 26, 2024 11:55
Copy link
Contributor

@bertranddemiddelaer bertranddemiddelaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcarmet tcarmet merged commit 337bbed into main Jun 26, 2024
4 checks passed
@tcarmet tcarmet deleted the bugfix/PTFE-1834-check-active-connection-prestop branch June 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants