Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node name width is too small in inspector when creating some nodes #446

Open
kephale opened this issue Jun 10, 2023 · 3 comments
Open

Node name width is too small in inspector when creating some nodes #446

kephale opened this issue Jun 10, 2023 · 3 comments

Comments

@kephale
Copy link
Member

kephale commented Jun 10, 2023

To recreate:

  1. Launch SciView
  2. Demo > Basic > Lines

The Name of the node is smaller in the inspector UI than it should be.

image
@kephale
Copy link
Member Author

kephale commented Jun 13, 2023

The text box in the tree view does get updated once you click on the Name text box in the properties panel.

@kephale
Copy link
Member Author

kephale commented Jun 13, 2023

@moreApi I think you did something like this recently. I suspect the problem is that we are using scenery's setName on a sciview node and the update doesn't trigger a tree refresh, here:

sciView.addLine( points, Colors.LIGHTSALMON, edgeWidth ).setName( "Lines Demo" );

How do we fix these things?

@moreApi
Copy link
Member

moreApi commented Jun 14, 2023

I did some property change watching for my network stuff, but there I looked actively.

Since we have no system in place to listen to property changes, we have to manually trigger an update if the name is changed, build something of a property change observable or look each frame for a change.

The text of the field is updated right? Then we "just" need to find where that happens and update the size of the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants