Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node publication API slicker #489

Open
ctrueden opened this issue Jun 14, 2023 · 5 comments
Open

Make node publication API slicker #489

ctrueden opened this issue Jun 14, 2023 · 5 comments
Milestone

Comments

@ctrueden
Copy link
Member

Right now the pattern is:

var v = sciview.addVolume(...)
v.addChild(mesh)
sciview.publishNode(mesh)

Would be nice if there were an API to make this pattern emerge automatically, by rolling the publication into one of the other API calls or some such.

If the idea is to "build up" the volume's structure before publishing the finished product, maybe we could use a builder pattern, or some kotlinesque/functional thing?

var v = sciview.addVolume(...).withConfig { it.addChild(mesh) }

Such that publication happens when the withConfig finishes? There are surely a few different ways to pet this particular cat, just wondering if we can reduce the chance of forgetting to publish after setting things up.

@ctrueden ctrueden added this to the unscheduled milestone Jun 14, 2023
@ctrueden ctrueden changed the title Find a way to make Make node publication API slicker Jun 14, 2023
@moreApi
Copy link
Member

moreApi commented Jun 15, 2023

#433 this already cleans up the addVolume methods. Maybe this issue could also be resolved there.

@moreApi
Copy link
Member

moreApi commented Jun 15, 2023

#497 related

@kephale
Copy link
Member

kephale commented Feb 19, 2024

I think it might be possible to close this since #497

@kephale
Copy link
Member

kephale commented Jun 3, 2024

@ctrueden is this closable?

@ctrueden
Copy link
Member Author

I haven't had time to play with the revised API yet, but would defer to others on whether they think it's friendly enough now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants