Update Hyrax submodule #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
approved these changes
Jun 7, 2024
Build was throwing error: Hyrax::SimpleSchemaLoader::UndefinedSchemaError: No schema defined: mobius_work
We were getting this error: ``` KeyError: Factory not registered: “hyrax_admin_set” ``` Ultimately we synced up everything with Pals Knapsack which made this work.
What I did is copy the submodule's Gemfile.lock to the Knapsack in order to maintain a synchronized Gemfile.lock for specs. Also, fixed lint, and added the byebug_history to gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs #205
Expected Behavior Before Changes
View all collectionsbutton on homepage does not find anythingtypesdoes not include collectionsExpected Behavior After Changes
This fixes
All Collectionsbutton now finds collectionsScreenshots / Video
Screenshots
Notes