Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request lib? #44

Open
cktang88 opened this issue Dec 25, 2018 · 6 comments
Open

Replace request lib? #44

cktang88 opened this issue Dec 25, 2018 · 6 comments

Comments

@cktang88
Copy link

Request is really bloated, and since it seems to only be used here to make a simple GET request, we can easily replace it with something lighter like got or axios. See https://bundlephobia.com/result?p=request@2.88.0

@ethan7g
Copy link

ethan7g commented Dec 28, 2018

Hi, I proposed a similar solution last year to this problem with PR #36. (phin is more lightweight than got, to my knowledge.)

@tettoffensive
Copy link

And now request is deprecated.

@LincolnPuzey
Copy link

There is #56 currently open replacing it with got

@SVillette
Copy link

Any news about this issue ? #56 was closed

@donmccurdy
Copy link

Perhaps the thing to do would be using the native Fetch API in Node.js v18, and cut a get-pixels@v4 release? Current Node.js LTS, v16, reaches end of life in September, and we may not need a dependency at all after that.

I'd be happy to make a PR for this change, if @mikolalysenko would be comfortable reviewing it.

@donmccurdy
Copy link

Possible workaround: #62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants