-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When building sdist, file symlink remains a symlink instead of being copied to a concrete file #801
Comments
Makes sense; the test matched the problem, which was a folder and not a file. One question though; would it make sense to leave symlinks that point to files that are in the SDist? |
I thoughts simlinks are not respected or is this only for wheels? If possible preserving symlinks within the sdist would be nice. One of the checks in Fedora is if files are bitwise identical which triggers warnings. Preserving the symlink would help if files in the sdist are to be installed. |
Symlinks are not possible in wheels, as they are based on zips (currently, there's a proposal to add a way to do it via marker file(s) being prepared, last I heard). SDists can contain them, in theory. It might be a problem on some Windows boxes since symlinks may be off. By the time you install (will go though a wheel), they will have to be real files. |
symlink-repro-1.zip
In the attached sample project, my package looks something like this
When I run in
my-python-package
folderthe source distribution file
scikit_build_simplest-0.0.1.tar.gz
in the dist folder (also included in the attached zip) looks like thisNotice how the folder symlink is correctly copied over as real folders, but the file symlink remains a file symlink instead of the real content. This makes this sdist unusable because
some-file.txt
is pointing to some path outside the sdist.I believe this is related to #359 but that fix only addresses the folder symlink, not the file symlink.
(NOT A CONTRIBUTION)
The text was updated successfully, but these errors were encountered: