Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify wheel builders #881

Open
LecrisUT opened this issue Aug 30, 2024 · 5 comments
Open

Unify wheel builders #881

LecrisUT opened this issue Aug 30, 2024 · 5 comments

Comments

@LecrisUT
Copy link
Collaborator

I was looking at why the hatch plugin isn't able to run as editable, and it seems that it is mostly because these are diverging implementations. I am thinking we should refactor these to make one common WheelBuilder with a build_wheel that is common with the plugins, and install_wheel that is specific to the build.build_wheel part. Any thoughts on how to approach this?

@henryiii
Copy link
Collaborator

henryiii commented Sep 7, 2024

This might not help with the Hatch plugin, as the reason it doesn't support editable installs is because it handles the wheel, not scikit-build-core. I was thinking we can't write a .pth files, it makes one for us. Though actually, maybe it can be done, I'm now wondering if it's possible.

builder is supposed to be the common code, and the stuff in build is wheel-specific. Plugins don't make wheels, they just provided files for setuptools/hatch/etc. to put in their wheels.

We should first see if we can do this with hatchling.

@ofek
Copy link
Contributor

ofek commented Sep 10, 2024

Creating files specifically for editable installations via build hooks is possible with the force_include_editable build data option.

@LecrisUT
Copy link
Collaborator Author

Creating files specifically for editable installations via build hooks is possible with the force_include_editable build data option.

Hmm, but does hatchling provide its own .pth editable file and if so would adding a file with the same name basically override it?

@ofek
Copy link
Contributor

ofek commented Sep 10, 2024

There is one for the project itself based on the name, prefixed by an underscore.

@henryiii
Copy link
Collaborator

Yes, we'd need to make sure it's unique. And I'm not sure how they might interact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants