Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JES file naming convention for Run3 breaks FactorizedJetCorrector #1111

Open
valsdav opened this issue Jun 17, 2024 · 1 comment
Open

JES file naming convention for Run3 breaks FactorizedJetCorrector #1111

valsdav opened this issue Jun 17, 2024 · 1 comment

Comments

@valsdav
Copy link
Contributor

valsdav commented Jun 17, 2024

https://github.com/CoffeaTeam/coffea/blob/f7e9119ba4567ba6a5e593da77627af475eae8e9/coffea/jetmet_tools/FactorizedJetCorrector.py#L75

  • Summer22EE_22Sep2023_RunF_V2_DATA_L1FastJet_AK4PFPuppi.txt.gz

________________^

  • Summer22EE_22Sep2023_RunF_V2_DATA_L2Relative_AK4PFPuppi.txt.gz
  • Summer22EE_22Sep2023_RunF_V2_DATA_L2L3Residual_AK4PFPuppi.txt.gz

The additional underscore breaks the naming convention. Do you recommend just renaming the files of patching the module?

@lgray
Copy link
Collaborator

lgray commented Jun 17, 2024

For now, I would just change a _ to a -. This will be better fixed with the correctionlib implementation that Andrea Piccinelli will be working on for the CorrectedJetsFactory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants