Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize Ruff config, use ruff-format #536

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Nov 16, 2023

Modernize Ruff config. Waiting on the next release (which adds better Jupyter notebook support) for ruff-format. (Now released)

See scientific-python/cookie#299.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0ee165) 95.80% compared to head (a13e7a1) 95.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   95.80%   95.80%   -0.01%     
==========================================
  Files          33       33              
  Lines        1407     1406       -1     
==========================================
- Hits         1348     1347       -1     
  Misses         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii force-pushed the henryiii/chore/modernizeruff branch from 2fcc202 to c8584b5 Compare November 17, 2023 19:37
@henryiii henryiii changed the title chore: modernize Ruff config chore: modernize Ruff config, use ruff-format Nov 17, 2023
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/chore/modernizeruff branch from c8584b5 to 0de42c9 Compare November 21, 2023 13:47
@eduardo-rodrigues eduardo-rodrigues added ⚙️ enhancement New feature or request CI labels Nov 21, 2023
@henryiii
Copy link
Member Author

Does anything need to be done here?

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. All good to me. I simply forgot to reply.

@eduardo-rodrigues eduardo-rodrigues merged commit 610bec1 into master Nov 27, 2023
13 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the henryiii/chore/modernizeruff branch November 27, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ⚙️ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants