Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore hatch vs. nox for managing high level developer workflows #2096

Open
matthewfeickert opened this issue Jan 19, 2023 · 5 comments
Open
Assignees
Labels
research experimental stuff

Comments

@matthewfeickert
Copy link
Member

Need to decide if we can use hatch envs with the current workflows that we have around nox (which I don't want to change in this PR) or if we'll need to remove hatch envs for the time being and make an Issue to decide how to move forward using nox and hatch in the future.

Originally posted by @matthewfeickert in #2095 (comment)

@ofek
Copy link
Contributor

ofek commented Jan 20, 2023

Let me know if you have any questions! Environment management and configuration is probably the feature I put the most thought and design work into so I'm interested to see how this goes 🙂

@matthewfeickert
Copy link
Member Author

Based on #2118 (comment) @kratsg and @agoose77 do you have any clever thoughts on how to determine if tensorflow or tensorflow-macos should be installed at runtime depending on if the user is on an Apple silicon Mac or not while using hatch environments?

@ofek
Copy link
Contributor

ofek commented Feb 16, 2023

Do environment markers not work for this use case?

@matthewfeickert
Copy link
Member Author

Do environment markers not work for this use case?

Yes, yes they will. Thanks @ofek! (I actually do generally read the docs for projects, but I also usually post these GitHub comments as reminders to do so when it isn't after midnight local time for me).

The way that hatchling does this is actually super nice, so many thanks for all the work that went into this design. 👍

@matthewfeickert matthewfeickert self-assigned this Feb 16, 2023
@matthewfeickert
Copy link
Member Author

hatchling environment markers now enabling PR #2119. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research experimental stuff
Projects
None yet
Development

No branches or pull requests

2 participants