Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonschema v4.18.0 will introduce breaking changes #2139

Open
matthewfeickert opened this issue Mar 17, 2023 · 2 comments
Open

jsonschema v4.18.0 will introduce breaking changes #2139

matthewfeickert opened this issue Mar 17, 2023 · 2 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@matthewfeickert
Copy link
Member

Using jsonschema 4.18.0a1 in the release candidate tests causes the tests to fail as the following DeprecationWarning is introduced when jsonschema.RefResolver is used.

DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.

This will require new releases of pyhf to fix to avoid causing future problems for cabinetry and other downstream users.

@matthewfeickert matthewfeickert added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 17, 2023
@kratsg
Copy link
Contributor

kratsg commented Mar 17, 2023

See #2121

@matthewfeickert
Copy link
Member Author

Nice. Thanks for being on top of this.

matthewfeickert added a commit that referenced this issue Jul 6, 2023
…Warning (#2246)

* Add an ignore to filterwarnings to avoid jsonschema.RefResolver DeprecationWarning

> DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor
> of the https://github.com/python-jsonschema/referencing library, which provides
> more compliant referencing behavior as well as more flexible APIs for customization.
> A future release will remove RefResolver. Please file a feature request
> (on referencing) if you are missing an API for the kind of customization you need.

  This filterwarning should be removed once pyhf updates to referencing.
  - c.f. #2139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
Status: To do
Development

No branches or pull requests

2 participants