Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange output - video recording presented #15

Open
CuteWaterBeary opened this issue Nov 15, 2024 · 8 comments
Open

Strange output - video recording presented #15

CuteWaterBeary opened this issue Nov 15, 2024 · 8 comments

Comments

@CuteWaterBeary
Copy link

Why are there 2 span elements being created before the code area? This is a really cool plugin - I've looked through every single one and this is the only one that doesn't insert html into the markdown but it has some hiccups.

inlineAdmonitions2.mp4
@scottTomaszewski
Copy link
Owner

Seems to just be a blank video to me
image

When I make an inline admonition in my vault it looks like this:
image

(in this example, its a prefix type with ! as the trigger.

If youre in Live Preview mode it looks like this:
image

  • The first span is the opening backtick
  • The second span is the actual inline-codeblock with a nested span for the content
  • The third span is the closing backtick

I might be able to get rid of the second, outer span if its causing issues, but its added to make the code easier between Reading view and Live Preview mode.

@CuteWaterBeary
Copy link
Author

CuteWaterBeary commented Nov 15, 2024

Screen Shot 2024-11-15 at 12 13 15 PM

Sorry about that. Its these 2 span elements before the code area. This is the live preview editing mode

@scottTomaszewski
Copy link
Owner

Oh... yeah that doesnt look good. Can you post your raw markdown? Im guessing its supposed to be

`.y2 hmm`

@CuteWaterBeary
Copy link
Author

inlineAdmonitions.mp4

Here's the video again without HEVC+265 compression. It should show everything you need but if it still doesnt work I'll post screenshots of the parts

@alythobani
Copy link

alythobani commented Dec 4, 2024

Yeah I get the same in Live Preview mode:

Screen Shot 2024-12-04 at 7 01 07 AM

In Source mode:

Screen Shot 2024-12-04 at 7 01 39 AM

In Live Preview mode with the cursor inside the admonition:

Screen Shot 2024-12-04 at 7 04 49 AM

In Reading mode:

Screen Shot 2024-12-04 at 7 03 22 AM

@scottTomaszewski
Copy link
Owner

My time has been a little short recently, but ive been thinking about this. My guess is that the css for inline-admonitions are conflicting with some of the tag css (which Im piggy-backing on). Im going to try rewriting the css to avoid accidentally inheriting any unwanted styling.

Curious, do either of you have any custom css? If so, does it affect codeblocks and/or tag visuals? Likewise, do you have any plugins that modify tags/codeblocks?

@alythobani
Copy link

My time has been a little short recently,

I relate wholeheartedly :)

Likewise, do you have any plugins that modify tags/codeblocks?

Ahh good catch - on my end, disabling the Code Styler plugin fixes this.

Also, interestingly, after re-enabling Code Styler, the two plugins work fine together:

Screen Shot 2024-12-04 at 7 20 18 AM

Except for in Reading Mode:

Screen Shot 2024-12-04 at 7 21 15 AM

But this half-fix depends on the order of which plugin was (re-)enabled last. If I toggle Inline Admonitions on/off, the bug re-appears in Live Preview / editing mode:

Screen Shot 2024-12-04 at 7 22 57 AM

So it's presumably some sort of overlapping / overriding code styling between the two plugins.

@scottTomaszewski
Copy link
Owner

Ah, thats very insightful! Okay, there is another issue ive been trying to deal with and I think the changes will also fix this... maybe. Thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants