Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Menu no longer works after clean OS install #14

Open
sheckylovejoy opened this issue Feb 17, 2016 · 14 comments
Open

RSS Menu no longer works after clean OS install #14

sheckylovejoy opened this issue Feb 17, 2016 · 14 comments

Comments

@sheckylovejoy
Copy link

Was having a lot of problems so I did a clean OS install and reinstalled all software, including RSS Menu, which I've always found useful. However, I have not been able to get it working. I just deleted and reinstalled, but it still won't work.

Behavior:
Looks fine at first:
screen shot 2016-02-17 at 9 20 22 am

and clicking
screen shot 2016-02-17 at 9 20 34 am

But then after selecting nothing happens and the button becomes greyed out
screen shot 2016-02-17 at 9 20 50 am

Thanks

@scottishwildcat
Copy link
Owner

Thanks for the report. Which version of OS X and Safari are you using? And can you give me an example of a website where you're seeing this behaviour? (I assume it appears to be "all of them", but a specific one I can check against would still be useful...)

@sheckylovejoy
Copy link
Author

Sorry, forgot that stuff

Mac Pro 2010
OS X 10.10.5 (14F1605)
Safari Version 9.0.3 (10601.4.4)

@sheckylovejoy
Copy link
Author

Also, FWIW, I also experience the weird behavior in issue #13. It's strange, but not a showstopper

@scottishwildcat
Copy link
Owner

Thanks. My dev machine is on 10.10.5 as well, so that at least gives me a fighting chance of figuring it out...

As for #13, last time I looked into it there didn't appear to be anything I could do about Safari's "Add to shared links" prompt, unfortunately.... have seen other people complaining about it too.

@sheckylovejoy
Copy link
Author

Also, RSS reader is Readkit and it is set as default reader if that matters. Also, to clarify, everything worked fine previous to the clean install, but I did not transfer any preferences over to the new install, so everything got set back to default prefs

@scottishwildcat
Copy link
Owner

And just to confirm, you're using the latest version (2.2.0) of the extension, yes?

@sheckylovejoy
Copy link
Author

screen shot 2016-02-17 at 10 29 45 am

@scottishwildcat
Copy link
Owner

Thanks. Can you try the debug version of the extension I've attached here?

  • Uninstall or disable the current extension
  • Unzip and install the debug extension
  • Restart Safari (just so it's starting from a clean slate)
  • Open some tabs that have RSS feeds
  • Open the extension prefs, and click the "Download Log" checkbox

That will save a debug log file to your usual download location, that you can send me or paste here.

RSSMenu-220-debug.safariextz.zip

@sheckylovejoy
Copy link
Author

Here's the log. Don't know if you could tell, but some of the sites I tried worked, while others just had the greyed out RSS Menu button

RSS Menu debug log.txt

@scottishwildcat
Copy link
Owner

That's useful, thanks. I still can't reproduce the problem so far, but the log does show that the extension isn't finding the same number of feeds for you as it is for me on a couple of those websites (longform.org and theringer.com), which seems a little odd. Will poke around a bit more.

Forgot to ask, do you have any other extensions installed?

@sheckylovejoy
Copy link
Author

screen shot 2016-02-19 at 12 25 44 pm
I've had these all even when it was working

@scottishwildcat
Copy link
Owner

Thanks. Have a couple of those myself, will download the other just to make sure there's nothing weird going on depending on what order they're loaded, or something daft like that.

@scottishwildcat
Copy link
Owner

Found and fixed a couple of bugs in the attached version that were certainly causing the button to sometimes be greyed out when it shouldn't have been (mainly when re-opening a recently closed page). Doubt it'll fix all the problems you mentioned, but give it a go and let me know if it's any better.

(I've beefed up the debug logging a bit more too, so if it's still not working, send me another log and we'll take it from there...)

RSSMenu-221-debug.safariextz.zip

@sheckylovejoy
Copy link
Author

Thanks for the quick turnaround. I'm shutdown for the night but I'll look at it tomorrow.

scottishwildcat added a commit that referenced this issue Nov 5, 2016
…gHandler() in global.html. Don't think this used to be necessary, but in Safari 9, when re-opening a recently closed/cached page, the feeds were found, but event.target.url in msgHandler() evaluated to undefined rather than the url of the newly loaded page. So the feeds were not correctly added to the allFeeds[] list, and the button remained disabled. (Found while investigating github issue #14.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants