Add ability to parse Annex B stream in FU-A #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some cameras (e.g. v380 pro) send Annex B stream in FU-A, which is not conformant to spec add logic that checks for Annex B in FU-As and goes out of way to read stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add ability to break apart an Annex B stream sent in a FU-A. Fixes #68
Details
My V380 cam would send a FU-A after establishing RTSP connection. The FU-A was not conformant to spec.
Notice how all the frags have the same header (as they should be), but the start has an Annex B stream, meaning the last NAL picked from that packet is an IDR. This means the last NAL saved from first packet will be an IDR, but the next fragment will have... the header for SPS, but data for IDR, which is wrong.
It appears that the camera only does this for FU-A that has SPS & PPS. FU-As & single NAL units for other NAL types are conformant to spec.
I have only modified this logic for the FU-A flow.
Camera details
Name: V380 (It's a generic V380 outdoor camera)
Firmware:
HwV380E31_WF8_PTZ_WIFI_20201218(I had asked them for a firmware update file to enable RTSP support)