-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to follow 301 and 302 redirection #93
base: main
Are you sure you want to change the base?
Conversation
Hi, RTSP follows HTTP which also sends Authorization header to redirected target. |
ef4ca8c
to
8ffe41c
Compare
Change the option to |
@scottlamb Gentle ping |
Hey, I know you've been waiting a long time on this. I'm uncomfortable though about the security implications of sending the credentials to another host.
Can you point me at where the spec mandates clients behave in that way? I can't find it, and I've read through the HTTP/1.1 spec (and specifically several versions of Here's a stackoverflow thread on the subject, fwiw, and it suggests other clients have made the choice to remove credentials on redirect. In your use case, are redirects happening to a different (scheme, host, port)? or is only the path changing? I'd be less concerned about...
trait CredentialStore {
fn get_credentials(url: &Url) -> Box<Future<Item = Result<Credentials, BoxError>>>
} |
Fix #92