Add codec features #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows users to strip some unneeded codec to reduce binary size
scottlamb
requested changes
Apr 18, 2024
There was a problem hiding this comment.
This seems totally reasonable but is technically a breaking change I believe, as if someone used retina = { version = "0.4", default-features = false } their code could be broken on upgrade.
Maybe it's time to bump to 0.5.0. There's at least one other breaking change I'll try to get out at the same time (making rfc6381_codec optional in video parameters.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows users to strip some unneeded codec to reduce binary size.
cargo bloat --all-features:After
cargo bloat --no-default-features: