Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json and atom feeds might be invalid #620

Open
jonatan-ivanov opened this issue Sep 30, 2023 · 7 comments
Open

json and atom feeds might be invalid #620

jonatan-ivanov opened this issue Sep 30, 2023 · 7 comments
Labels

Comments

@jonatan-ivanov
Copy link
Contributor

Json and atom feeds were introduced in #604. When I try to add them on feedly, both fail. The W3C feed validation service also says that the atom feed is invalid.

@jespino
Copy link
Contributor

jespino commented Oct 5, 2023

I can take care of this :)

@scraly
Copy link
Owner

scraly commented Oct 5, 2023

thanks :)

@scraly
Copy link
Owner

scraly commented Oct 13, 2023

atom feed is now valid

@jonatan-ivanov
Copy link
Contributor Author

jonatan-ivanov commented Oct 13, 2023

Thank you!

Unfortunately, I'm still not able to add it to Feedly, as it seems @jespino was not able to do it either.

I have two guesses for that, neither should be an issue I think but we don't really know why feedly does not work:

  1. The validator still prints out a warning for this:
<link rel="self" href="https://developers.events/feed-events.atom"/>

Which is not the link to the feed, the feed is under /feed-events.xml.
2. This also makes me wondering that Atom feed urls usually (not always) use the .atom extension instead of xml (I guess mainly to distinguish between .atom and .rss but I'm not an expert in either of those).

@scraly scraly added bug and removed hacktoberfest labels Oct 22, 2023
@scraly
Copy link
Owner

scraly commented Oct 22, 2023

I fixed the warning (in #707) for ATOM feed but we still can't import ATOM and JSON feeds on feedly

@scraly
Copy link
Owner

scraly commented Oct 22, 2023

By the way, atom feed accepts .atom and .xml

@jonatan-ivanov
Copy link
Contributor Author

Thank you for fixing it.
Yeah, it should not matter, neither of the above should be an issue I think for any readers but now that this is fixed and feedly is still broken, I'm out of ideas.

I tweeted them, let's see if they reply: https://twitter.com/jonatan_ivanov/status/1716279676631716019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants