Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Can we standardize the codebase to use tabs instead of spaces? #865

Open
HanzCEO opened this issue Feb 8, 2024 · 2 comments
Open

Comments

@HanzCEO
Copy link
Contributor

HanzCEO commented Feb 8, 2024

Good morning, I'm back,

I have seen many inconsistencies within our code base (especially the page/ directory) and I want to propose a solution. Can we standardize the tab size to be equivalent as 4 spaces?

Any feedback is appreciated.

Regards,
Hanz

@jonatan-ivanov
Copy link
Contributor

https://editorconfig.org/ can be a good option for this, e.g.:

root = true

[*]
end_of_line = lf
insert_final_newline = true
charset = utf-8
indent_style = tab
trim_trailing_whitespace = true

...

Regarding the ancient tabs vs spaces debate, I recommend reading this: https://www.reddit.com/r/javascript/comments/c8drjo/nobody_talks_about_the_real_reason_to_use_tabs/
(Open Source projects usually consider the accessibility angle.)

@HanzCEO
Copy link
Contributor Author

HanzCEO commented Feb 10, 2024

Regarding the ancient tabs vs spaces debate, I recommend reading this: https://www.reddit.com/r/javascript/comments/c8drjo/nobody_talks_about_the_real_reason_to_use_tabs/ (Open Source projects usually consider the accessibility angle.)

Thank you for the insights. I might not form my sentence properly, but I usually use tabs instead of spaces. I just thought that everyone contributing here use spaces, so I try to conform to the culture.

@HanzCEO HanzCEO changed the title Proposal: Can we standardize the tab size as 4? Proposal: Can we standardize use tabs instead of spaces? Feb 10, 2024
@HanzCEO HanzCEO changed the title Proposal: Can we standardize use tabs instead of spaces? Proposal: Can we standardize the codebase to use tabs instead of spaces? Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants