You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thanks a lot for the repo it helped me a lot on implementing kamal.
I would like to point out a small improvement (or keep it here as a reference) with secrets being injected. The current build creates a .env on build time, however, that would produce docker images being tagged with "uncommitted" changes tag. So to avoid that, we can pass secrets on a more "kamal way".
So public params can be added directly on the deployment file and secret ones will be read from .kamal/secrets. The secrets will be read from env variables $BASE_URL injected from GH.
Thanks.
The text was updated successfully, but these errors were encountered:
First of all, thanks a lot for the repo it helped me a lot on implementing kamal.
I would like to point out a small improvement (or keep it here as a reference) with secrets being injected. The current build creates a .env on build time, however, that would produce docker images being tagged with "uncommitted" changes tag. So to avoid that, we can pass secrets on a more "kamal way".
So public params can be added directly on the deployment file and secret ones will be read from .kamal/secrets. The secrets will be read from env variables $BASE_URL injected from GH.
Thanks.
The text was updated successfully, but these errors were encountered: