Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets injection #1

Open
pedroct92 opened this issue Nov 22, 2024 · 0 comments
Open

Secrets injection #1

pedroct92 opened this issue Nov 22, 2024 · 0 comments

Comments

@pedroct92
Copy link

First of all, thanks a lot for the repo it helped me a lot on implementing kamal.

I would like to point out a small improvement (or keep it here as a reference) with secrets being injected. The current build creates a .env on build time, however, that would produce docker images being tagged with "uncommitted" changes tag. So to avoid that, we can pass secrets on a more "kamal way".

env:
 clear:
   NEXT_PUBLIC_TOTO: 123abc
 secret:
   - BASE_URL 

So public params can be added directly on the deployment file and secret ones will be read from .kamal/secrets. The secrets will be read from env variables $BASE_URL injected from GH.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant