fix: fix parsed hook response (#16)

* fix: fix parsed hook response

* fix: add log info

index.js

@@ -3,6 +3,7 @@
 const Scm = require('screwdriver-scm-base');
 const async = require('async');
 const hoek = require('hoek');
+const winston = require('winston');
 
 class ScmRouter extends Scm {
     /**
@@ -94,7 +95,7 @@ class ScmRouter extends Scm {
      * @return {Promise}                     scm object
      */
     chooseWebhookScm(headers, payload) {
-        return new Promise((resolve, reject) => {
+        return new Promise((resolve) => {
             // choose a webhook scm module, or null if there is no suitable one
             async.detect(this.scms, (scm, cb) => {
                 scm.canHandleWebhook(headers, payload)
@@ -103,13 +104,7 @@ class ScmRouter extends Scm {
                     }).catch(() => {
                         cb(null);
                     });
-            }, (ret) => {
-                if (ret === null) {
-                    return reject(new Error('there is no suitable webhook module'));
-                }
-
-                return resolve(ret);
-            });
+            }, ret => resolve(ret));
         });
     }
 
@@ -177,7 +172,16 @@ class ScmRouter extends Scm {
      * @return {Promise}
      */
     _parseHook(headers, payload) {
-        return this.chooseWebhookScm(headers, payload).then(scm => scm.parseHook(headers, payload));
+        return this.chooseWebhookScm(headers, payload)
+            .then((scm) => {
+                if (!scm) {
+                    winston.info('Webhook does not match any expected events or actions.');
+
+                    return null;
+                }
+
+                return scm.parseHook(headers, payload);
+            });
     }
 
     /**

package.json

@@ -43,7 +43,8 @@
   },
   "dependencies": {
     "async": "^2.6.1",
-    "screwdriver-scm-base": "^5.0.0"
+    "screwdriver-scm-base": "^5.0.0",
+    "winston": "^3.1.0"
   },
   "release": {
     "debug": false,