Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically annotate performance graphs with dependency changes #490

Open
soyacz opened this issue Oct 24, 2024 · 0 comments · May be fixed by #502
Open

Automatically annotate performance graphs with dependency changes #490

soyacz opened this issue Oct 24, 2024 · 0 comments · May be fixed by #502
Assignees

Comments

@soyacz
Copy link
Collaborator

soyacz commented Oct 24, 2024

Problem:

Changes in important dependencies such as driver versions, load tool versions, kernel versions, or Scylla Manager versions can introduce performance regressions. These changes are often difficult to detect during the manual performance review process, as there is no immediate visual indication correlating dependency changes with observed performance metrics.

Solution:

Automatically annotate performance graphs when a dependency change is detected to help correlate changes in performance with system alterations. This will be achieved as follows:

  1. Automatic Detection: During data retrieval from the database, the system will pull information about dependencies (e.g., driver version, kernel version) associated with each data point. When a change in any dependency is detected, an annotation will be generated.

  2. Visual Annotation: A horizontal line will be placed on the graph at the point where the dependency change occurred. The line will represent the time of the change and will not extend across the graph. A new line will be placed for each detected change.

  3. Tooltip Information: When a user hovers over the annotation, a tooltip will display detailed information about the change, including:

    • The name of the package (e.g., driver, kernel, Scylla Manager).
    • The specific version that the package was updated to.
@soyacz soyacz self-assigned this Oct 24, 2024
soyacz added a commit to soyacz/argus that referenced this issue Nov 13, 2024
In performance tests it's important to note changes of dependencies,
like kernel, drivers, stress tools.

This commit changes the way point is displayed (gets white background)
and adds changed packages details to the tooltip.

closes: scylladb#490
@soyacz soyacz linked a pull request Nov 13, 2024 that will close this issue
soyacz added a commit to soyacz/argus that referenced this issue Nov 13, 2024
In performance tests it's important to note changes of dependencies,
like kernel, drivers, stress tools.

This commit changes the way point is displayed (gets white background)
and adds changed packages details to the tooltip.

closes: scylladb#490
soyacz added a commit to soyacz/argus that referenced this issue Nov 14, 2024
In performance tests it's important to note changes of dependencies,
like kernel, drivers, stress tools and SUT version.

This commit changes the way point is displayed:
when there's package change (except SUT change) then the point gets
a white background.
Hovering over the point shows tooltip with all packages changes
(including SUT).

Tooltip position was adjusted to be show above the point so mouse is not
covering text.

closes: scylladb#490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants