Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output layout improvement #73

Open
pveentjer opened this issue Aug 25, 2021 · 0 comments
Open

Output layout improvement #73

pveentjer opened this issue Aug 25, 2021 · 0 comments

Comments

@pveentjer
Copy link

pveentjer commented Aug 25, 2021

In the output the columns do not always line up:

12m41.2s  407603  407603      0 60ms   28ms   12ms   2.7ms  1.8ms  852µs  1.3ms  
12m41.6s  402153  402153      0 49ms   27ms   7.8ms  2.6ms  2ms    950µs  1.3ms  
12m41.7s  419139  419139      0 128ms  43ms   14ms   3.4ms  2.2ms  950µs  1.5ms  
12m42s  401019  401019      0 48ms   29ms   9.1ms  2.3ms  1.7ms  852µs  1.2ms  
12m42.2s  401227  401227      0 41ms   25ms   8.7ms  2.3ms  1.7ms  819µs  1.1ms  
12m42.6s  398582  398582      0 49ms   27ms   11ms   2.8ms  2ms    950µs  1.3ms  
12m42.7s  391801  391801      0 88ms   43ms   14ms   3.2ms  2.1ms  918µs  1.5ms  
12m43s  398790  398790      0 51ms   29ms   11ms   2.6ms  1.8ms  852µs  1.2ms  

So when there is no fractional part, everything is shifted 2 characters to the left.

dkropachev added a commit to dkropachev/scylla-bench that referenced this issue Feb 28, 2022
Fix following things:
1. Get rid of 2 histograms per thread to reduce memory usage
2. Make latency printing non-blocking
3. Reorganize code
4. Get rid of histogram merging

fixes scylladb#80, scylladb#49, scylladb#73, scylladb#69
dkropachev added a commit to dkropachev/scylla-bench that referenced this issue Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant