Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another DALI driver #48

Closed
rnixx opened this issue Oct 4, 2018 · 7 comments · Fixed by #59
Closed

Another DALI driver #48

rnixx opened this issue Oct 4, 2018 · 7 comments · Fixed by #59

Comments

@rnixx
Copy link
Contributor

rnixx commented Oct 4, 2018

Since there's some drive about DALI drivers at the moment i want to place my latest finding here as well

https://git.unipi.technology/UniPi/unipi-python-lighting/blob/master/UnipiDali/unipidali.py

maybe it ends up in the driver collection somewhen

@mhemeryck
Copy link
Contributor

Had a similar question: if I would submit a PR for including it here, would you pull it in?

I so, I will also bring the ppl from unipi in the loop.

@rnixx
Copy link
Contributor Author

rnixx commented Jun 5, 2019

You might check whether license is ok (LGPL). Then i think there's no reason not to merge. @sde1000 ?

@sde1000
Copy link
Owner

sde1000 commented Jun 5, 2019

I'm away on holiday at the moment, I'll have a look next Tuesday.

@mhemeryck
Copy link
Contributor

No sweat, I'm only starting to look into DALI right now, might take some time to actually create the PR.

On a side note, I was also considering to prettify the code a bit: automated linting, pinning dependencies, ... How do you feel about this? Probably a different topic / issue ...

@rnixx
Copy link
Contributor Author

rnixx commented Jun 5, 2019

@mhemeryck please do not mix features an cleanup. btw - this package has no dependencies

@mhemeryck
Copy link
Contributor

I agree to not mix this feature with any possible cleanup -- I'll first look into the unipi driver (since I'll actually need that one quite soon).

On the dependency note: I did notice you were using the package usb somewhere, which isn't a standard python package. I assume it's pyusb? Anyways, I will try to get back to that in another topic like you suggested. I just already noted it since I couldn't run that project directly.

@rnixx
Copy link
Contributor Author

rnixx commented Jun 5, 2019

@mhemeryck ah right, yes. pyusb is needed for hasseb and tridonic drivers, my fault.

If you're further interested to contribute, there's another driver left to be adopted to the correct API (#54).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants