From 10af7868a87fda67c97b01936f553c1cf8b87b64 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20S=C3=A1nchez-Gallego?= <gallegoj@uw.edu>
Date: Sat, 15 Jun 2024 03:19:32 +0000
Subject: [PATCH] More complete enclosure status

---
 src/lvmapi/routers/enclosure.py | 83 ++++++++++++++++++++++++++-------
 src/lvmapi/tools/rabbitmq.py    | 14 ++++--
 2 files changed, 76 insertions(+), 21 deletions(-)

diff --git a/src/lvmapi/routers/enclosure.py b/src/lvmapi/routers/enclosure.py
index 3afe8ab..15d56ab 100644
--- a/src/lvmapi/routers/enclosure.py
+++ b/src/lvmapi/routers/enclosure.py
@@ -8,37 +8,88 @@
 
 from __future__ import annotations
 
-from fastapi import APIRouter, HTTPException, Request
-from pydantic import BaseModel
+from typing import Any
 
-from lvmapi.tools.gort import get_gort_client
+from fastapi import APIRouter, HTTPException
+from pydantic import BaseModel, field_validator
+
+from lvmapi.tools.rabbitmq import send_clu_command
+
+
+router = APIRouter(prefix="/enclosure", tags=["enclosure"])
+
+
+class PLCStatus(BaseModel):
+    """A model to represent a PLC sensor or function."""
+
+    name: str
+    value: int
+    labels: list[str] = []
+
+    @field_validator("value", mode="before")
+    def cast_value(cls, value: str) -> int:
+        return int(value, 16)
+
+    @field_validator("labels", mode="after")
+    def trim_labels(cls, value: list[str]) -> list[str]:
+        return list(map(str.strip, value))
+
+
+class O2Status(BaseModel):
+    """Status of the O2 sensors."""
+
+    utilities_room: float
+    spectrograph_room: float
 
 
 class EnclosureStatus(BaseModel):
-    """Status of the telescope enclosure."""
+    """A model to represent the status of the enclosure."""
 
-    open: bool
-    moving: bool
+    registers: dict[str, bool | float | int]
 
+    dome_status: PLCStatus
+    safety_status: PLCStatus
+    lights_status: PLCStatus
 
-router = APIRouter(prefix="/enclosure", tags=["enclosure"])
+    o2_status: O2Status
 
 
 @router.get("/")
 @router.get("/status")
-async def status(request: Request) -> EnclosureStatus:
+async def status() -> EnclosureStatus:
     """Performs an emergency shutdown of the enclosure and telescopes."""
 
     try:
-        async with get_gort_client(request.app) as gort:
-            status = await gort.enclosure.status()
+        ecp_status = await send_clu_command("lvmecp status")
     except Exception as ee:
-
         raise HTTPException(status_code=500, detail=str(ee))
 
-    dome_status_labels = status["dome_status_labels"]
+    status_data: dict[str, Any] = {}
+    for reply in ecp_status:
+        if "registers" in reply:
+            status_data["registers"] = reply["registers"]
+        elif "dome_status" in reply:
+            status_data["dome_status"] = {
+                "name": "dome",
+                "value": reply["dome_status"],
+                "labels": reply["dome_status_labels"].split(","),
+            }
+        elif "lights" in reply:
+            status_data["lights_status"] = {
+                "name": "lights",
+                "value": reply["lights"],
+                "labels": reply["lights_labels"].split(","),
+            }
+        elif "safety_status" in reply:
+            status_data["safety_status"] = {
+                "name": "safety",
+                "value": reply["safety_status"],
+                "labels": reply["safety_status_labels"].split(","),
+            }
+        elif "o2_percent_utilities" in reply:
+            status_data["o2_status"] = {
+                "utilities_room": reply["o2_percent_utilities"],
+                "spectrograph_room": reply["o2_percent_spectrograph"],
+            }
 
-    return EnclosureStatus(
-        open=("OPEN" in dome_status_labels),
-        moving=("MOVING" in dome_status_labels),
-    )
+    return EnclosureStatus(**status_data)
diff --git a/src/lvmapi/tools/rabbitmq.py b/src/lvmapi/tools/rabbitmq.py
index 5230233..63eaafd 100644
--- a/src/lvmapi/tools/rabbitmq.py
+++ b/src/lvmapi/tools/rabbitmq.py
@@ -21,7 +21,7 @@
     from clu import Command
 
 
-__all__ = ["CluClient", "send_command"]
+__all__ = ["CluClient", "send_clu_command"]
 
 
 class CluClient:
@@ -91,7 +91,11 @@ def clear(cls):
 
 
 @overload
-async def send_command(
+async def send_clu_command(command_string: str) -> list[dict[str, Any]]: ...
+
+
+@overload
+async def send_clu_command(
     command_string: str,
     *,
     raw: Literal[False],
@@ -99,7 +103,7 @@ async def send_command(
 
 
 @overload
-async def send_command(
+async def send_clu_command(
     command_string: str,
     *,
     raw: Literal[True],
@@ -107,14 +111,14 @@ async def send_command(
 
 
 @overload
-async def send_command(
+async def send_clu_command(
     command_string: str,
     *,
     raw: bool,
 ) -> list[dict[str, Any]] | Command: ...
 
 
-async def send_command(
+async def send_clu_command(
     command_string: str,
     *,
     raw=False,