Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore new endpoint for uploading file #59

Open
havok2063 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #62
Open

Explore new endpoint for uploading file #59

havok2063 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #62
Labels
enhancement New feature or request

Comments

@havok2063
Copy link
Contributor

Explore option for new endpoint for uploading a file with a list of targets ids or coordinates to search on. Related to sdss/zora#70. We'll need to think about whether this route would do the search, or if it should only validate the file inputs and the return the validated targets, to allow the user to append query options to it. We don't necessarily want to maintain a third way for people to search.
@havok2063 havok2063 added the enhancement New feature or request label Sep 30, 2024
@havok2063 havok2063 mentioned this issue Oct 18, 2024
Open
havok2063 added a commit that referenced this issue Oct 18, 2024
@havok2063
Add endpoint for uploading file with target IDs or coordinates
fa30480 
Fixes #59

Add a new endpoint for uploading a file with a list of target IDs or coordinates to search on.

* Add a new endpoint in `python/valis/routes/query.py` to handle file uploads and process the contents for target searches.
* Validate the file inputs, extract target IDs or coordinates, and perform the search.
* Validate the target IDs in the uploaded file and return an error response with a clear message indicating the invalid IDs if any are found.
* Support CSV and TXT file formats for upload.
* Add unit tests in `tests/test_queries.py` for the new endpoint to handle file uploads and process the contents for target searches.
* Test validation of the file inputs, extraction of target IDs or coordinates, and performing a fake search.
* Test validation of the target IDs in the uploaded file and returning an error response with a clear message indicating the invalid IDs if any are found.
* Test support for CSV and TXT file formats for upload.
* Test for both target ids and coordinates.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sdss/valis/issues/59?shareId=XXXX-XXXX-XXXX-XXXX).
@havok2063 havok2063 linked a pull request Oct 18, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add endpoint for uploading file with target IDs or coordinates sdss/valis
1 participant
@havok2063