[REQUEST] Adding a visit should mark as visited

[nebriv]

Hey Sean!

Just getting started here and am poking around Adventure Log. Looks like the start to something great.

I was adding an Adventure in and noticed that if I added a visit date, it doesn't mark it as visited. I would think this should automatically Mark as Visited? Not sure if I fully understand the Visits section, maybe a check for a past date first?

Seems like this was added recently:
#306 (comment)

Keep up the good work! As I get comfortable I'll see if I can tackle some issues as well with a few PRs.

Thanks!

[seanmorley15]

Hi @nebriv! I think I know what you are referring to. If you are referring to world regions being marked as already visited when trying to create an adventure, I just discovered that to be a bug and released a fix right now (re pulling latest tag should fix). The issue was them not being filtered properly. Now, when selecting a location on the map it should prompt you to mark the location as visited.

Let me know if this helps or if I am missing something!
Also, any help no matter how small is greatly appreciated! I am willing to help you along the way too if you have any questions :)
Thanks!

[nebriv]

Hey hey!

Nope that button works perfectly! I mean this section:

If I have a visit recorded in the past, I think it would be safe to assume we could mark it as visited (without having to click the "Mark as visited" button)?

[seanmorley15]

Right now, the regions are not marked automatically. It is up to the user to decide if they want to mark the world travel regions as visited. This is because they may not have a date set or it might be a future plan.
There is an option in settings to search all adventures to bulk mark detected and visited regions.

After writing this, I see it makes sense to auto mark it after saving if a past date is entered and region is detected. I can get this done for v0.8.0 that I am working on right now.
Let me know if this sounds good!

[nebriv]

Sounds awesome! :)