From ce3b13929c6e202b61826316241ea2eabbc8b235 Mon Sep 17 00:00:00 2001
From: Sebastian Feldmann <sebastianfeldmann@users.noreply.github.com>
Date: Sun, 24 Nov 2024 20:01:32 +0100
Subject: [PATCH] Fix Dropbox sync

In order to support short-lived tokens we have to provide a
refresh token, which can be obtained from the Dropbox api.

Fixes issue #362
---
 doc/config/sync/dropbox.json |  2 +-
 doc/config/sync/dropbox.xml  |  2 +-
 src/Backup/Sync/Dropbox.php  | 41 +++++++++++++++++++++---------------
 3 files changed, 26 insertions(+), 19 deletions(-)

diff --git a/doc/config/sync/dropbox.json b/doc/config/sync/dropbox.json
index c6d2545..49841a9 100644
--- a/doc/config/sync/dropbox.json
+++ b/doc/config/sync/dropbox.json
@@ -1,7 +1,7 @@
 {
   "type": "dropbox",
   "options": {
-    "token": "myCrazyLongApiTokenThatIGotFromDropbox",
+    "refreshToken": "myCrazyLongRefreshTokenThatIGotFromDropbox",
     "appKey": "myAppKey",
     "appSecret": "myAppSecret",
     "path": "/some/dir"
diff --git a/doc/config/sync/dropbox.xml b/doc/config/sync/dropbox.xml
index bd98f7b..8c5f77e 100644
--- a/doc/config/sync/dropbox.xml
+++ b/doc/config/sync/dropbox.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <sync type="dropbox">
   <!-- mandatory -->
-  <option name="token" value="mycrazylongapitokenthatigotfromdropbox" />
+  <option name="refreshToken" value="mycrazylongrefreshtokenthatigotfromdropbox" />
 
   <!-- mandatory -->
   <option name="appKey" value="myAppKey" />
diff --git a/src/Backup/Sync/Dropbox.php b/src/Backup/Sync/Dropbox.php
index 7b38960..60c85af 100644
--- a/src/Backup/Sync/Dropbox.php
+++ b/src/Backup/Sync/Dropbox.php
@@ -37,7 +37,17 @@ class Dropbox implements Simulator
      *
      * @var  string
      */
-    protected $token;
+    private $appKey;
+
+    /**
+     * @var string
+     */
+    private $appSecret;
+
+    /**
+     * @var string
+     */
+    protected $refreshToken;
 
     /**
      * Remote path
@@ -60,16 +70,6 @@ class Dropbox implements Simulator
      */
     protected $time;
 
-    /**
-     * @var string
-     */
-    private $appKey;
-
-    /**
-     * @var string
-     */
-    private $appSecret;
-
     /**
      * (non-PHPDoc)
      *
@@ -85,12 +85,12 @@ public function setup(array $config)
         }
 
         // check for mandatory options
-        $this->validateConfig($config, ['token', 'path', 'appKey', 'appSecret']);
+        $this->validateConfig($config, ['refreshToken', 'path', 'appKey', 'appSecret']);
 
-        $this->time      = time();
-        $this->token     = $config['token'];
-        $this->appKey    = $config['appKey'];
-        $this->appSecret = $config['appSecret'];
+        $this->time         = time();
+        $this->refreshToken = $config['refreshToken'];
+        $this->appKey       = $config['appKey'];
+        $this->appSecret    = $config['appSecret'];
         // make sure the path contains a leading slash
         $this->path  = new Path(Util\Path::withLeadingSlash($config['path']), $this->time);
 
@@ -179,7 +179,14 @@ protected function createCollector(Target $target) : Collector
     protected function createClient() : DropboxApi\Dropbox
     {
         if (!$this->client) {
-            $app          = new DropboxApi\DropboxApp($this->appKey, $this->appSecret, $this->token);
+            $app        = new DropboxApi\DropboxApp($this->appKey, $this->appSecret);
+            $client     = new DropboxApi\Dropbox($app);
+            $authHelper = $client->getAuthHelper();
+            $token      = $authHelper->getRefreshedAccessToken(
+                new DropboxApi\Models\AccessToken(['refresh_token' => $this->refreshToken])
+            );
+
+            $app          = new DropboxApi\DropboxApp($this->appKey, $this->appSecret, $token->getToken());
             $this->client = new DropboxApi\Dropbox($app);
         }
         return $this->client;