Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit code for cicd piplines #26

Open
flokain opened this issue Feb 5, 2020 · 0 comments
Open

exit code for cicd piplines #26

flokain opened this issue Feb 5, 2020 · 0 comments

Comments

@flokain
Copy link

flokain commented Feb 5, 2020

I am about to integrate dumpsterDiver in out cicd pipline at gitlab.

The way the tasks in the pipline works are that they run scripts and check the exit code to determine if the task was succesfull.

Proposal

it would be cool to have the posibility to check wether or not the "dive" was successfull. Depending on wether you use DD as security tool or hacking tool success is defined differently.

Suggestion 1

I suggest that if the tool runs through and finds something it exits with 0.
if it doesn't find anything it exits with 2.
if the code breaks it exits with code 1. (python standard i think)
therefore one can run the programm like so
[ $(python DumpsterDiver.py -p .....) -ne 2]

Suggestion 2

to Position it more as a security tool another way would be:

I suggest that if the tool runs through and finds something it exits with 2.
if it doesn't find anything it exits with 0.
if the code breaks it exits with code 1. (python standard i think)
which leads to the more elegant
python DumpsterDiver.py -p .....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant