Improve how the E.M type is detected to match fair data station properties #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to unexpected results found during testing.
whomingbird
approved these changes
Nov 20, 2024
whomingbird
reviewed
Nov 20, 2024
| score = (property_ids - pids).length | ||
| emt = nil if (property_ids & pids).empty? | ||
| [score, emt] | ||
| extended_metadata_property_ids = collect_extended_metadata_type_attibute_pids(emt) |
There was a problem hiding this comment.
Will properties in the datastation_entity that are not covered by the EMT be ignored?
There was a problem hiding this comment.
no, they are included in the difference score. It's why I used
(property_ids | extended_metadata_property_ids) - intersection
instead of just
extended_metadata_property_ids - property_ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was discovered during testing, where it was matching the wrong EMType based on just the number of properties matching.
Now updated to downgrade matches based on the number of properties left over. So if 2 properties match all the properties of one type this will be chosen in preference to another where 2 also match, but there are several properties that don't match.