Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Custom logger #760

Open
Sloy opened this issue Mar 30, 2021 · 1 comment
Open

Feature request: Custom logger #760

Sloy opened this issue Mar 30, 2021 · 1 comment
Labels
improvement This has been identified as a feature improvement

Comments

@Sloy
Copy link
Contributor

Sloy commented Mar 30, 2021

This feature request is to allow passing a custom logger implementation to the Segment SDK. This will allow users to log errors somewhere different from the Logcat.

The motivation behind this request is that we have been investigating the source of some data discrepancies between Segment and our Database for a few months. We had to clone the SDK and modify it to send errors to Crashlytics, and that's how we found out that the API was returning us a lot of HTTP 400 errors because of #755. Even though the errors in the log don't explicitly say what the error is, they would help us a lot to know that we broke something in the future.

The implementation should be fairly simple because the Analytics constructor already receives the logger. It would need to be optionally provided by the Analytics.Builder.

Does this feature make sense to you? Are you open to PRs for it?

@prayansh
Copy link
Contributor

Custom logger definitely makes sense, although I do not think we will be working on this feature any time soon, unless priorities change.
We are definitely open to PRs for it and definitely encourage community contributions 😄

@prayansh prayansh added the improvement This has been identified as a feature improvement label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This has been identified as a feature improvement
Projects
None yet
Development

No branches or pull requests

2 participants