From 0bd31abd92cd389c857af9ef8951b1c7f3f8a9a1 Mon Sep 17 00:00:00 2001 From: Samuel Gfeller <31797204+samuelgfeller@users.noreply.github.com> Date: Mon, 30 Oct 2023 12:31:47 +0100 Subject: [PATCH 1/3] Removed nyholm/psr7 warning It seems that query string parameters passed via arguments finally work with nyholm/psr7. https://github.com/Nyholm/psr7/pull/214 --- src/Traits/RouteTestTrait.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Traits/RouteTestTrait.php b/src/Traits/RouteTestTrait.php index 43eac50..839d3ef 100644 --- a/src/Traits/RouteTestTrait.php +++ b/src/Traits/RouteTestTrait.php @@ -15,9 +15,6 @@ trait RouteTestTrait * @param string $routeName Route name * @param string[] $data Named argument replacement data * @param string[] $queryParams Optional query string parameters. - * If you're using `nyholm/psr7`, query parameters MUST be added via - * `$request = $request->withQueryParams($queryParams)` - * to be retrieved with `$request->getQueryParams();` * * @return string The route with base path */ From ed65009b4c94c1018d7e03c4abc5eeab3515f0d8 Mon Sep 17 00:00:00 2001 From: Samuel Gfeller <31797204+samuelgfeller@users.noreply.github.com> Date: Mon, 30 Oct 2023 12:37:07 +0100 Subject: [PATCH 2/3] Removed dot --- src/Traits/RouteTestTrait.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Traits/RouteTestTrait.php b/src/Traits/RouteTestTrait.php index 839d3ef..cf5a814 100644 --- a/src/Traits/RouteTestTrait.php +++ b/src/Traits/RouteTestTrait.php @@ -14,7 +14,7 @@ trait RouteTestTrait * * @param string $routeName Route name * @param string[] $data Named argument replacement data - * @param string[] $queryParams Optional query string parameters. + * @param string[] $queryParams Optional query string parameters * * @return string The route with base path */ From 06e4463a30e17d0e657be933be7d095bda8d58bd Mon Sep 17 00:00:00 2001 From: Samuel Gfeller <31797204+samuelgfeller@users.noreply.github.com> Date: Mon, 30 Oct 2023 12:45:37 +0100 Subject: [PATCH 3/3] Adjusted phpdoc to match routeparserinterface urlFor doc --- src/Traits/RouteTestTrait.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Traits/RouteTestTrait.php b/src/Traits/RouteTestTrait.php index cf5a814..6b91dd8 100644 --- a/src/Traits/RouteTestTrait.php +++ b/src/Traits/RouteTestTrait.php @@ -13,8 +13,8 @@ trait RouteTestTrait * Build the path for a named route including the base path. * * @param string $routeName Route name - * @param string[] $data Named argument replacement data - * @param string[] $queryParams Optional query string parameters + * @param array $data Named argument replacement data + * @param array $queryParams Optional query string parameters * * @return string The route with base path */