Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Error Code Format #69

Closed
CodyRay opened this issue Apr 10, 2016 · 3 comments
Closed

Change Error Code Format #69

CodyRay opened this issue Apr 10, 2016 · 3 comments

Comments

@CodyRay
Copy link
Member

CodyRay commented Apr 10, 2016

Should look more like SD1001. Currently, our diagnostic ids are: SemDiffFP, SemDiffFN, and SemDiff

@CodyRay
Copy link
Member Author

CodyRay commented Apr 18, 2016

This is my proposed scheme:

Code Explanation ...
SD0001 Method has been moved locally but changed remotely *
SD0002 Method has been changed locally but moved remotely *
SD0003 Base class has been changed remotely
SD0004 File has been changed locally and changed or renamed remotly %
SD1001 Unknown Internal Error
SD1002 GitHub Unauthenticated Rate Limit hit
SD1003 Git repo does not have a GitHub repository as a remote
SD1004 GitHub Authentication Error
SD1005 GitHub Authenticated Rate Limit hit +

*: This would be a new distinction, at this point they are handled with the same message

%: This would be a new a new diagnostic that would enable us to handle renamed and changed files.

+: This could also just be part of SD1002, making it just "Rate Limit"

@CodyRay
Copy link
Member Author

CodyRay commented Apr 23, 2016

@MRose90 feedback change numbing scheme. I also removed the authenticated rate limit.

Code Explanation
SD0001 Method has been moved locally but changed remotely
SD0002 Method has been changed locally but moved remotely
SD0003 Base class has been changed remotely
SD0004 File has been changed locally and changed or renamed remotely
SD1001 Unknown Internal Error
SD2001 GitHub Rate Limit hit
SD2002 Git repo does not have a GitHub repository as a remote
SD2003 GitHub Authentication Error

@CodyRay CodyRay mentioned this issue Apr 24, 2016
@CodyRay
Copy link
Member Author

CodyRay commented Apr 28, 2016

Error messages have been completed. SD0004 is not wired in at this time, but #37 will remain open until that is completed

@CodyRay CodyRay closed this as completed Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant