From ea87ae58042beb017ac1e466582491b78bda4836 Mon Sep 17 00:00:00 2001 From: Joseph Edwards Date: Fri, 23 Feb 2024 11:54:58 +0000 Subject: [PATCH 1/2] update Joe's info --- .mailmap | 2 +- PackageInfo.g | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap index ae17a11e6..e8e8d472f 100644 --- a/.mailmap +++ b/.mailmap @@ -3,7 +3,7 @@ Stuart Burrell stuartburrell Reinis Cirpons Reinis Cirpons <43414125+reiniscirpons@users.noreply.github.com> Reinis Cirpons reiniscirpons Tom Conti-Leslie Tom Conti-Leslie <54725378+tomcontileslie@users.noreply.github.com> -Joe Edwards Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com> +Joseph Edwards Joseph Edwards <80713360+Joseph-Edwards@users.noreply.github.com> Luke Elliott le27 Fernando Flores Brito Fernando Flores Brito Nick Ham diff --git a/PackageInfo.g b/PackageInfo.g index 5bdb399f1..a1a26411b 100644 --- a/PackageInfo.g +++ b/PackageInfo.g @@ -114,10 +114,10 @@ Persons := [ rec( LastName := "Edwards", - FirstNames := "Joe", + FirstNames := "Joseph", IsAuthor := true, IsMaintainer := false, - Email := "je53@st-andrews.ac.uk", + Email := "jde1@st-andrews.ac.uk", PostalAddress := _STANDREWSMATHS, Place := "St Andrews", Institution := "University of St Andrews", From 055f34b7ddce65998244b7a3b0d2cfc5556d3802 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Fri, 8 Mar 2024 17:18:25 +0100 Subject: [PATCH 2/2] Workaround for GAP 4.12 test failure due to new GAPDoc version --- ci/run-gap-testinstall.g | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ci/run-gap-testinstall.g b/ci/run-gap-testinstall.g index 804953f22..f671dfd27 100644 --- a/ci/run-gap-testinstall.g +++ b/ci/run-gap-testinstall.g @@ -1 +1,8 @@ - Read(Filename(DirectoriesLibrary("tst"), "testinstall.g")); +# Using GAPDoc 1.6.7 with GAP version before 4.13.0 causes a (harmless) failure +# in a test file, which we work around by just deleting the offending +# test file. +if not CompareVersionNumbers(ReplacedString(GAPInfo.Version, "dev", ""), "4.13") and + CompareVersionNumbers(PackageInfo("GAPDoc")[1].Version, "1.6.7") then + RemoveFile(Filename(DirectoriesLibrary("tst"), "testinstall/package.tst")); +fi; +Read(Filename(DirectoriesLibrary("tst"), "testinstall.g"));