Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Suspect Commit #78

Closed
sdzhong opened this issue Sep 6, 2023 · 5 comments
Closed

Show Suspect Commit #78

sdzhong opened this issue Sep 6, 2023 · 5 comments

Comments

@sdzhong
Copy link
Contributor

sdzhong commented Sep 6, 2023

Suspect Commit are not appearing on the flagship error (tda-generated, locally generated)

However, they were consistently appearing in tda-generated events and from a local run (event).

What is preventing Suspect Commit from consistently/reliably appearing?

@sdzhong
Copy link
Contributor Author

sdzhong commented Sep 6, 2023

May be related to getsentry/sentry#55013, since the Suspect Commit commit is > 1 year old.

Image

Next step: update the flagship error so git blame / Suspect Commit chooses a recent commit (less than 1 year old) instead

@sdzhong
Copy link
Contributor Author

sdzhong commented Sep 13, 2023

This may be resolved as a side-effect of #68

@sdzhong
Copy link
Contributor Author

sdzhong commented Oct 10, 2023

Suspect Commit appeared when running locally, e.g. when testing https://github.com/sentry-demos/android/tree/feat/profiling-issues, I see this event with Suspect Commit:

Image

I don't see it in subsequent events, though (whether those events are generated locally or via pytest).

@sdzhong
Copy link
Contributor Author

sdzhong commented Oct 17, 2023

Suspect Commit appears in 2.6.1

Example event URL
image

^Potential bug showing me as You committed and also sdzhong committed, both referring to me.

@sdzhong
Copy link
Contributor Author

sdzhong commented Oct 18, 2023

I’ve added the suggested email 89550162+sdzhong@users.noreply.github.com to https://demo.sentry.io/settings/account/emails/.
Now the event shows You committed for all.
image

@sdzhong sdzhong closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant